eolivelli commented on a change in pull request #389:
URL: https://github.com/apache/curator/pull/389#discussion_r667825920
##########
File path:
curator-framework/src/test/java/org/apache/curator/framework/imps/TestCleanState.java
##########
@@ -43,10 +44,8 @@ public static void closeAndTestClean(CuratorFramework client)
EnsembleTracker ensembleTracker =
internalClient.getEnsembleTracker();
if ( ensembleTracker != null )
{
- while ( ensembleTracker.hasOutstanding() )
- {
- Thread.sleep(100);
- }
+ Awaitility.await()
Review comment:
here you are adding an implicit timeout of 10 seconds
I am fine with it, as far as it does not make the test become flaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
