leandrodalbo commented on a change in pull request #382:
URL: https://github.com/apache/curator/pull/382#discussion_r680071580
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/EnsembleTracker.java
##########
@@ -211,7 +211,7 @@ private void processConfigData(byte[] data) throws Exception
}
else
{
- log.error("Invalid config event received: {}", properties);
+ log.debug("Invalid config event received: {}", properties);
Review comment:
@VisibleForTesting
public static String configToConnectionString(QuorumVerifier data)
throws Exception {
StringBuilder sb = new StringBuilder();
Iterator var2 = data.getAllMembers().values().iterator();
while(var2.hasNext()) {
QuorumServer server = (QuorumServer)var2.next();
if (server.clientAddr != null) {
if (sb.length() != 0) {
sb.append(",");
}
String hostAddress;
if (server.clientAddr.getAddress().isAnyLocalAddress()) {
hostAddress = Compatibility.getHostAddress(server);
} else {
hostAddress =
server.clientAddr.getAddress().getHostAddress();
}
sb.append(hostAddress).append(":").append(server.clientAddr.getPort());
}
}
return sb.toString();
}
- I think it is processing the version=0 like another server more when it
shouldn't.
- Do we know if this is affecting any functionality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
