[ https://issues.apache.org/jira/browse/CURATOR-232?focusedWorklogId=806371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806371 ]
ASF GitHub Bot logged work on CURATOR-232: ------------------------------------------ Author: ASF GitHub Bot Created on: 06/Sep/22 13:34 Start Date: 06/Sep/22 13:34 Worklog Time Spent: 10m Work Description: tisonkun closed pull request #89: CURATOR-232 Consolidate Timing and Client URL: https://github.com/apache/curator/pull/89 Issue Time Tracking ------------------- Worklog Id: (was: 806371) Time Spent: 20m (was: 10m) > Consolidate test code > --------------------- > > Key: CURATOR-232 > URL: https://issues.apache.org/jira/browse/CURATOR-232 > Project: Apache Curator > Issue Type: Improvement > Components: Tests > Reporter: Mike Drob > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Writing additional tests for Curator can be fairly intimidating to new users, > and it looks like things just get copy and pasted a lot. We can consolidate a > lot of test code, starting with how we expose {{Timing}} and > {{CuratorFramework}} objects. This is a probably going to be a longer term > effort with several JIRAs, so I'm not concerned with this one issue covering > absolutely everything, I just want to make new tests easier to write. > One easy route is to make heavier use of annotations, like the > {{@BeforeMethod}} and {{@AfterMethod}} instead of {{try/finally}} when making > sure resources are cleaned up. -- This message was sent by Atlassian Jira (v8.20.10#820010)