kezhuw commented on code in PR #421:
URL: https://github.com/apache/curator/pull/421#discussion_r1112741148
##########
curator-test/src/main/java/org/apache/curator/test/InstanceSpec.java:
##########
@@ -205,6 +205,10 @@ public int getQuorumPort()
return quorumPort;
}
+ /**
+ * @deprecated use {@link TestingServer#getConnectString()} or {@link
TestingCluster#getConnectString()} instead
+ */
+ @Deprecated
Review Comment:
I have removed `public` from `ZooKeeperMainFace`. @tisonkun
`getTickTime` needs reflection as `ZooKeeperServerEmbedded` exposes no such
info([ZOOKEEPER-4670](https://issues.apache.org/jira/browse/ZOOKEEPER-4670)).
In previous version(8eda7d0f73333a5e0781d38006065eac98a012a4), I exposed a get
method in `ZooKeeperMainFace` to retrieve `ServerCnxnFactory` where both
`getTickTime` and `getClientPort` could be easily constructed . But that
approach depends heavily on reflection as `QuorumPeerMain` and
`ZooKeeperServerEmbedded` exposes no such info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
