[
https://issues.apache.org/jira/browse/CURATOR-661?focusedWorklogId=847611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847611
]
ASF GitHub Bot logged work on CURATOR-661:
------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/23 08:49
Start Date: 25/Feb/23 08:49
Worklog Time Spent: 10m
Work Description: tisonkun commented on code in PR #444:
URL: https://github.com/apache/curator/pull/444#discussion_r1117890218
##########
.github/workflows/ci.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: CI
+
+on:
+ push:
+ branches: [master]
+ pull_request:
+ branches: [master]
+
+# Concurrency strategy:
+# github.workflow: distinguish this workflow from others
+# github.event_name: distinguish `push` event from `pull_request` event
+# github.event.number: set to the number of the pull request if
`pull_request` event
+# github.run_id: otherwise, it's a `push` event, only cancel if we rerun the
workflow
+#
+# Reference:
+# https://docs.github.com/en/actions/using-jobs/using-concurrency
+#
https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event_name }}-${{
github.event.number || github.run_id }}
+ cancel-in-progress: true
+
+env:
+ MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
-Dmaven.wagon.http.retryHandler.class=standard
-Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ check:
+ name: Check
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: Check license header
+ run: |
+ docker run --rm -v $(pwd):/github/workspace
ghcr.io/korandoru/hawkeye-native:v1 check
+
+ unittest:
+ name: Unit tests - JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ timeout-minutes: 120
+ strategy:
+ matrix:
+ java: ['8', '11']
+ steps:
+ - uses: actions/checkout@v3
+ - name: Cache local Maven repository
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ ${{ runner.os }}-maven-
+ - uses: actions/setup-java@v2
Review Comment:
```suggestion
- uses: actions/setup-java@v3
```
Issue Time Tracking
-------------------
Worklog Id: (was: 847611)
Time Spent: 20m (was: 10m)
> Cleanup and refactor build and CI settings
> ------------------------------------------
>
> Key: CURATOR-661
> URL: https://issues.apache.org/jira/browse/CURATOR-661
> Project: Apache Curator
> Issue Type: Improvement
> Reporter: Zili Chen
> Assignee: Zili Chen
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
