Thanks for your verification and suggestions!

Enrico said he would take a look at Monday, so I'll wait a bit. And I
can schedule to patch the suggestions :D

Best,
tison.

Kezhu Wang <kez...@gmail.com> 于2024年1月7日周日 20:10写道:
>
> Hi all,
>
> Thanks @tison for the release work!
>
> +1 binding
>
> I checked the following and all succeeded.
> * Ran "./mvnw verify" in jdk 8,11 and 21.
> * Matched md5, sha1 and signature of artifacts.
>
> I found the following problems but I think none of them are blockers
> and could be fixed before/after official announcement:
> * ReleaseNode contains "Unresolved" jira issues. I think we should
> update "Fix Version" for these issues before the official
> announcement.
> * Link for PGP KEYS is invalid now. It should be
> https://downloads.apache.org/curator/KEYS now. We might also want to
> fix this in the email template hosted on confluence wiki or our new
> website.
> * This is the first release after our new website, so I guess our
> download link in the "ANNOUNCE" email template should also be updated.
>
> Best,
> Kezhu Wang
>
> On Fri, Jan 5, 2024 at 11:12 PM tison <wander4...@gmail.com> wrote:
> >
> > +1 binding
> >
> > + Download links valid
> > + Checksum and signature matched
> > + LICENSE and NOTICE present
> > + Build and test
> >
> > Best,
> > tison.
> >
> > Jordan Zimmerman <jor...@jordanzimmerman.com> 于2024年1月5日周五 00:50写道:
> >
> > >
> > > +1 binding
> > >
> > > Tests pass
> > > Hash matches
> > > Signature verifies
> > >
> > > -JZ
> > >
> > > > On Jan 2, 2024, at 4:40 PM, tison <wander4...@gmail.com> wrote:
> > > >
> > > > Hello,
> > > >
> > > > This is the vote for Apache Curator version 5.6.0
> > > >
> > > > *** Please download, test and vote within approx. 72 hours
> > > >
> > > > Note that we are voting upon the source (tag) and binaries are
> > > > provided for convenience.
> > > >
> > > > Link to release notes:
> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353185&styleName=Text&projectId=12314425
> > > >
> > > > Staging repo:
> > > > https://dist.apache.org/repos/dist/dev/curator/5.6.0/
> > > >
> > > > Binary artifacts:
> > > > https://repository.apache.org/content/repositories/orgapachecurator-1057
> > > >
> > > > The tag to be voted upon:
> > > > https://github.com/apache/curator/releases/tag/apache-curator-5.6.0
> > > >
> > > > Curator's KEYS file containing PGP keys we use to sign the release:
> > > > https://www.apache.org/dist/curator/KEYS
> > > >
> > > > [ ] +1  approve
> > > > [ ] +0  no opinion
> > > > [ ] -1  disapprove (and reason why)
> > > >
> > > > Best,
> > > > tison.
> > >

Reply via email to