Re: [I] [CURATOR-67] Issue with default JSONInstanceSerializer for discovery service builder [curator]

[via GitHub]

jira-importer commented on issue #588:
URL: https://github.com/apache/curator/issues/588#issuecomment-2604700890

   <i><a 
href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot";>githubbot</a>:</i>
   <p>Github user cammckenzie commented on a diff in the pull request:</p>
   
   <p>    <a 
href="https://github.com/apache/curator/pull/30#discussion_r15737880"; 
class="external-link" target="_blank" rel="nofollow 
noopener">https://github.com/apache/curator/pull/30#discussion_r15737880</a></p>
   
   <p>    &#8212; Diff: 
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceDiscoveryBuilder.java
 &#8212;<br/>
       @@ -29,6 +29,7 @@<br/>
    private String  basePath;<br/>
    private InstanceSerializer<T>   serializer;<br/>
    private ServiceInstance<T>      thisInstance;<br/>
       +    private Class<T>payloadClass;</p>
   
   <p> /**</p>
   <ul>
        <li>Return a new builder. The builder will be defaulted with a 
   {@link JsonInstanceSerializer}
   <p>.</p>
        <ul class="alternate" type="square">
                <li>
                <ul class="alternate" type="square">
                        <li>End diff &#8211;</li>
                </ul>
                </li>
        </ul>
        </li>
   </ul>
   
   
   <p>    This comment about defaulting the serializer should be moved to the 
build() method.</p>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org