jira-importer commented on issue #592: URL: https://github.com/apache/curator/issues/592#issuecomment-2604701465
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot";>githubbot</a>:</i> <p>GitHub user madrob opened a pull request:</p> <p> <a href="https://github.com/apache/curator/pull/31"; class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/curator/pull/31</a></p> <p> <a href="https://issues.apache.org/jira/browse/CURATOR-71"; title="Error message in StandardLockInternalsDriver for retryable lock acquire error" class="issue-link" data-issue-key="CURATOR-71"><del>CURATOR-71</del></a> do not log-and-throw</p> <p> If we throw an exception, then there is no point in logging it since<br/> something further up the call stack already has to deal with it. At<br/> best, the exception gets logged twice, at worst we log potentially<br/> confusing exceptions that end up not mattering.</p> <p>You can merge this pull request into a Git repository by running:</p> <p> $ git pull <a href="https://github.com/madrob/curator"; class="external-link" target="_blank" rel="nofollow noopener">https://github.com/madrob/curator</a> <a href="https://issues.apache.org/jira/browse/CURATOR-71"; title="Error message in StandardLockInternalsDriver for retryable lock acquire error" class="issue-link" data-issue-key="CURATOR-71"><del>CURATOR-71</del></a></p> <p>Alternatively you can review and apply these changes as the patch at:</p> <p> <a href="https://github.com/apache/curator/pull/31.patch"; class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/curator/pull/31.patch</a></p> <p>To close this pull request, make a commit to your master/trunk branch<br/> with (at least) the following in the commit message:</p> <p> This closes #31</p> <hr /> <p>commit 35278cc1b52802995ee5db017bcc84dba7c69a70<br/> Author: Mike Drob <md...@cloudera.com><br/> Date: 2014-08-01T17:08:47Z</p> <p> <a href="https://issues.apache.org/jira/browse/CURATOR-71"; title="Error message in StandardLockInternalsDriver for retryable lock acquire error" class="issue-link" data-issue-key="CURATOR-71"><del>CURATOR-71</del></a> do not log-and-throw</p> <p> If we throw an exception, then there is no point in logging it since<br/> something further up the call stack already has to deal with it. At<br/> best, the exception gets logged twice, at worst we log potentially<br/> confusing exceptions that end up not mattering.</p> <hr /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
