[
https://issues.apache.org/jira/browse/CURATOR-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617744#comment-13617744
]
Shevek commented on CURATOR-7:
------------------------------
ConnectionState.checkTimeouts resets the connection if the session timeout has
expired, whether or not we ever had a session. If one has a large, shooty
cluster with a short session timeout and a long connection timeout, this might
reset the host list pointer to zero every sessionTimeoutMs, never letting it
connect to a valid, available host towards the end of the list. On the other
hand, if it is an assertion that sessionTimeout > connectionTimeout always,
then the min() call is not required and the ifelse should read "else if
(elapsed > connectionTimeoutMs)" instead of just "else".
> Session ids not preserved if EnsembleProvider has changed the ensemble
> ----------------------------------------------------------------------
>
> Key: CURATOR-7
> URL: https://issues.apache.org/jira/browse/CURATOR-7
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client
> Affects Versions: 2.0.0
> Reporter: Shevek
> Assignee: Jordan Zimmerman
>
> See https://github.com/Netflix/curator/issues/266
> InterProcessMutex, LeaderLatch, etc use an ephemeral node. If ZooKeeper gives
> a Disconnected event, the native client reconnects with the same session id,
> and the ephemeral node is preserved. If the ensemble changes at any point
> before a Disconnect, Curator's ConnectionState#checkState() calls
> handleNewConnectionString(), which constructs a new native ZK client,
> discarding the previous session id, and losing all locks.
> This can be expensive.
> Can ConnectionState be made to preserve the session id, or be more
> conservative about discarding the entire native client on a Disconnected
> event?
> Clarifications:
> An ensemble change (e.g. adding a new node to a cluster) does not mean that
> all session ids are now invalid. The next network glitch should not break
> locks.
> There is no assumption in this description that the reconfiguration and the
> glitch/disconnection were related - they need not be.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
