Hi Willem I see now... I will add a failing test to JAXRSContinuationsTest suite and apply your patch. many thanks :-)
Sergey On Fri, Nov 19, 2010 at 12:24 AM, Willem Jiang <[email protected]>wrote: > On 11/18/10 8:49 PM, Sergey Beryozkin wrote: > >> Hi Willem >> >> thanks for working on it. The patch looks fine. >> >> Can you just explain please why the changes are needed given that >> JAXRSContinuationsTest is passing at the moment. >> > I just went through the JAXRSContinuationsTest, it doesn't test the > getSubResource part. > > I found the issue by running the camel-cxf test of > CxfRsRouterTest.testGetSubResource()[1] > > > I suspect it is because the (Camel) code which relies on the enhanced CXF >> continuations code stresses the JAXRSInvoker differently, i.e, the >> suspended >> invocation is not coming back through the JAXRSInInterceptor ? >> > No, the CXF continuations API is not change, I just changed the underlay > implementation. When continuation suspend is called, we need to recover the > stats of ResourceProvider and ServiceObject in the exchange to make the > JAXRSInvoker.invoke() method recallable. > > > [1] > https://svn.apache.org/repos/asf/camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/jaxrs/CxfRsRouterTest.java > > > >> cheers, Sergey >> >> >> On Thu, Nov 18, 2010 at 10:18 AM, Willem Jiang<[email protected] >> >wrote: >> >> Hi, >>> >>> I did some clean up work[1] on the CxfRsInvoker in Camel to let it work >>> better with CXF 2.3.0 continuation API. >>> >>> Current JAXRSInvoker is not friendly to extends, and the method >>> public Object invoke(Exchange exchange, Object request) >>> is stateful and can't be called by the continuation resume process. >>> >>> Please check this issue[2] for the patch. >>> >>> >>> [1]http://svn.apache.org/viewvc?rev=1036343&view=rev >>> [2]https://issues.apache.org/jira/browse/CXF-3133 >>> -- >>> Willem >>> ---------------------------------- >>> FuseSource >>> Web: http://www.fusesource.com >>> Blog: http://willemjiang.blogspot.com (English) >>> http://jnn.javaeye.com (Chinese) >>> Twitter: willemjiang >>> >>> >> > > -- > Willem > ---------------------------------- > FuseSource > Web: http://www.fusesource.com > Blog: http://willemjiang.blogspot.com (English) > http://jnn.javaeye.com (Chinese) > Twitter: willemjiang >
