Hi,

Just a proposal for small improvements in Wss4jInInterceptor.
Normally CryptoProvider doesn't instantiated directly via CryptoFactory, but 
firstly tried to be obtained from message context properties 
(SecurityConstants.ENCRYPT_CRYPTO, SecurityConstants.SIGNATURE_CRYPTO). And 
only if the properties are not set, CryptoProvider is instantiated via 
CryptoFactory. This gives the possibility to replace Merlin CryptoProvider to 
custom one (probably non keystore based).
AbstractBindingBuilder, XmlSignHandler, SAMLUtils are working in this way.

Unfortunatelly it is not the case for Wss4jInInterceptor. It doesn't 
initializes crypto provider in RequestData and crypto provider is always 
created via CryptoFactory. It makes impossible to use custom implementation of 
CryptoProvider in incoming chain.

I have created Jira 4049 with a patch.

Regards,
Andrei.

Reply via email to