Github user reta commented on a diff in the pull request:

    https://github.com/apache/cxf/pull/149#discussion_r73263806
  
    --- Diff: 
integration/cdi/src/main/java/org/apache/cxf/cdi/JAXRSCdiResourceExtension.java 
---
    @@ -179,7 +185,13 @@ private JAXRSServerFactoryBean 
createFactoryInstance(final Application applicati
                     classified.get(Path.class).add(singleton);
                 }
             }
    -        
    +
    +        // now loop through the classes
    +        Set<Class<?>> classes = application.getClasses();
    +        if (!classes.isEmpty()) {
    +            classified.get(Path.class).addAll(loadServices(beanManager, 
classes));
    +            
classified.get(Provider.class).addAll(loadProviders(beanManager, classes));
    --- End diff --
    
    Would you mind to add Feature.class as well? Yeah, it is CXF, not JAX-RS 
feature, but it won't hurt to have the same behavior as with singletons. Minor 
comment though, leaving choice to you. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to