Hi John,

Thanks a lot for your fixes, much appreciated and of great value for CDI
users. To answer a couple of your questions / concerns.

JDA> First, its assuming that Weld is the only testable container.

This is very true. The reason for that is Weld was the only one implementing
CDI 1.2 at the moment the CXF/CDI integration was done. OpenWebBeans were 
behind but there is no obstacles or objects to have a test suite(s) against
it as well, it's been a while OpenWebBeans implements 1.2.

JDA> Second, its always doing classpath scanning. 

This is also true, as there was an intention to test exactly the way it is
going to be used. The suite also tests against Tomcat and Jetty, embedded and
WAR based deployments. With that being said, if Arquillian allows to simplify
the test structure while opening more opportuties to test different scenarios 
(including the ones we already have), it would be great in my opinion. 

Thanks.

Best Regards,
Andriy Redko

JDA> Hi,

JDA> Long time user, first time contributor to CXF.  Though I'm no stranger to
JDA> the ASF by any long shot.

JDA> I was looking at putting in some fixes for issues I reported.  First one
JDA> was a non-problem.  However, when trying to figure out how to add tests to
JDA> ensure that empty application class applications work fine (CXF-6986), I
JDA> realized that the current testing structure in systest wouldn't work.

JDA> 
https://github.com/apache/cxf/blob/master/systests/cdi/src/test/java/org/apache/cxf/systest/jaxrs/cdi/AbstractCDITest.java

JDA> It looks like this test code is doing a few odd things.  First, its
JDA> assuming that Weld is the only testable container.  The ASF actually hosts
JDA> the other CDI impl, OpenWebBeans.  Second, its always doing classpath
JDA> scanning.  This strategy would mean I need a separate module to test my
JDA> feature, which is a little odd.

JDA> I was wondering if there was any interest in converting this to an
JDA> arquillian based test?  The test code could be platform inspecific,
JDA> allowing tests to be created for both CDI impls, improving compatibility.

JDA> WDYT?
JDA> in case it helps understand the problem, my proposed changes can be seen
JDA> here: https://github.com/apache/cxf/pull/150

JDA> - John

Reply via email to