CXF Checkstyle seems to have a strange preference for import ordering. I am also often hit by this.
I think this is defined in etc/eclipse/CXF.importorder.
Not sure how to get eclipse to use it though.

Christian

On 10.08.2016 12:17, Sergey Beryozkin wrote:
Hi

Having static imports always has Checkstyle complaining for me.
I'm fine with the new tests contributed which have the static imports that pass the command line builds :-). Refactoring the existing tests - are you referring to all of CXF unit tests ?
Sergey

On 10/08/16 11:09, Behrang Saeedzadeh wrote:
Hi,

I have noticed some test cases extend Assert (e.g. JwkUtilsTest
<https://github.com/apache/cxf/blob/e6ce20a8fb434abb5ff34f769e63ac1c71f919b0/rt/rs/security/jose-parent/jose/src/test/java/org/apache/cxf/rs/security/jose/jwk/JwkUtilsTest.java>)
while some test cases don't.

I assume the extending Assert is a pre Java-5 style as back then we didn't
have static imports.

Any objections to refactor these test cases and make them extend nothing
(well, Object) and instead use static imports?

Best regards,
Behrang Saeedzadeh




--
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
http://www.talend.com

Reply via email to