sberyozkin commented on issue #315: [CXF-7512] Support searching swaggerUi by name and version in all bun? URL: https://github.com/apache/cxf/pull/315#issuecomment-331410019 Hi Christian, many thanks. The original pattern looks cleaner to me (we apply it in various places in CXF - proxies - CGLIB or not, and Class resolution and scanning, probably in other places too), as opposed to having the code which is not relevant for the non-OSGI case which will guarantee 2 Throwable will always be thrown and caught and a non-reachable code in the end in the OSGI case if the bundle is installed and of no use - if it's not installed (it checks URLClassLoader), and all of that 'bundled' in a single function body. I'd like to propose that we deprecate 'swaggerUiMavenGroupAndArtifact' and have you new 'swaggerUiName' property being the only property used by the resolvers. We'd be able to use this property in the non-OSGI case too (to find the correct jar if needed). In OSGI case, as I suggested earlier, we just check if the name contains '/' then it is Maven otherwise it is a bundle name only. See many people know the Maven artifacts but finding the bundle name requires more work so if people use Maven artifacts it is just simpler for then to use the artifacts, 'swagger-ui' is not a very uniique value to be honest...Anyway, we'd still be able to use a single OSGI Resolver and be able to skip the Maven related code in the short term if the user sets a swaggerUiName property without '/' ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
