cschneider commented on issue #331: [CXF-7535] Adding client & server support for Project Reactor URL: https://github.com/apache/cxf/pull/331#issuecomment-342719451 I would keep tests with the module unless they are slow or very involved. We spawn CXF endpoints in a lot of other modules tests. The full cxf build takes quite a while. So it is very useful to be able to build a single module and get some good feedback if it is correct. One other thing about the tests. There are a lot of sleeps in the tests. This is not good. I propose to replace this with Awaitility based retries. For example: assertEquals("Hello, world!", holder.value); could be: Awaitility.await().until(()->holder.value, equalTo("Hello world!"));
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
