joel-shemtov commented on issue #343: Modify error message on failure to close synchronous conduit URL: https://github.com/apache/cxf/pull/343#issuecomment-346635521 I don't know for sure whether or not the message has been sent. I have seen, as a user, cases where the message has been sent then. Indeed it might not be the case in these build tests. Considering your comment, I will revert the changes I've made to the testing code. Instead I'll set a much finer criterion for placing this new error message. If it fails the test, I will know for sure that the and try to pass it again. It will be something like: ` public static class MessageSenderEndingInterceptor extends AbstractPhaseInterceptor<Message> { public MessageSenderEndingInterceptor() { super(Phase.PREPARE_SEND_ENDING); } public void handleMessage(Message message) throws Fault { try { getConduit(message).close(message); } catch (SocketTimeoutException e) { throw new Fault(new org.apache.cxf.common.i18n.Message("COULD_NOT_COMLETE", BUNDLE), e); } catch (IOException e) { throw new Fault(new org.apache.cxf.common.i18n.Message("COULD_NOT_SEND", BUNDLE), e); } } } ` where the first catch clause is the only addition to the current code. Would it not be better to close this pull request and open a fresh new one?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
