Hi Dan, Just FYI, this change somehow break cxf-xjc-plugin build, I can see error like
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:checkstyle (validate) on project cxf-xjc-plugin: An error has occurred in Checkstyle report generation.: Failed during checkstyle configuration: cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of SuppressionCommentFilter -> [Help 1] Google a bit, seems checkstyle 8.1 has some regression[1] [1]https://github.com/checkstyle/checkstyle/issues/4841 <https://github.com/checkstyle/checkstyle/issues/4841> Thanks! －－－－－－－－－－－－－ Freeman(Yue) Fang Red Hat, Inc. FuseSource is now part of Red Hat > On Jan 4, 2018, at 3:59 AM, [email protected] wrote: > > This is an automated email from the ASF dual-hosted git repository. > > dkulp pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/cxf-build-utils.git > > > The following commit(s) were added to refs/heads/master by this push: > new eb8bcd9 Updates to checkstyle rules to support checkstyle 8.x which > is now used in eclipse > eb8bcd9 is described below > > commit eb8bcd948c29fceffee170821c8514fe1843c571 > Author: Daniel Kulp <[email protected]> > AuthorDate: Wed Jan 3 14:59:07 2018 -0500 > > Updates to checkstyle rules to support checkstyle 8.x which is now used in > eclipse > --- > .../src/main/resources/cxf-checkstyle-corba.xml | 4 +--- > buildtools/src/main/resources/cxf-checkstyle.xml | 20 +++++++++----------- > 2 files changed, 10 insertions(+), 14 deletions(-) > > diff --git a/buildtools/src/main/resources/cxf-checkstyle-corba.xml > b/buildtools/src/main/resources/cxf-checkstyle-corba.xml > index 8bc42da..2ace74b 100644 > --- a/buildtools/src/main/resources/cxf-checkstyle-corba.xml > +++ b/buildtools/src/main/resources/cxf-checkstyle-corba.xml > @@ -44,8 +44,6 @@ > <!--<module name="StrictDuplicateCode"/>--> > > <module name="TreeWalker"> > - <!-- Enable FileContentsHolder to allow us to in turn turn on > suppression comments --> > - <module name="FileContentsHolder" /> > <!-- Checks for Javadoc comments. --> > <!-- See http://checkstyle.sf.net/config_javadoc.html --> > <!-- > @@ -288,8 +286,8 @@ > <property name="lineWrappingIndentation" value="0"/> > </module> > <!--<module name="RequiredRegexp">--> > + <module name="SuppressionCommentFilter"/> > </module> > - <module name="SuppressionCommentFilter"/> > <!-- Header checks --> > <module name="Header"> > <property name="header" > diff --git a/buildtools/src/main/resources/cxf-checkstyle.xml > b/buildtools/src/main/resources/cxf-checkstyle.xml > index 5aedf6b..8c964f4 100644 > --- a/buildtools/src/main/resources/cxf-checkstyle.xml > +++ b/buildtools/src/main/resources/cxf-checkstyle.xml > @@ -46,8 +46,6 @@ > <!--<module name="StrictDuplicateCode"/>--> > > <module name="TreeWalker"> > - <!-- Enable FileContentsHolder to allow us to in turn turn on > suppression comments --> > - <module name="FileContentsHolder" /> > <!-- Checks for Javadoc comments. --> > <!-- See http://checkstyle.sf.net/config_javadoc.html --> > <!-- > @@ -280,17 +278,17 @@ > <property name="lineWrappingIndentation" value="0"/> > </module> > <!--<module name="RequiredRegexp">--> > + <module name="SuppressionCommentFilter"> > + <property name="offCommentFormat" value="CHECKSTYLE\:OFF"/> > + <property name="onCommentFormat" value="CHECKSTYLE\:ON"/> > + </module> > + <module name="SuppressionCommentFilter"> > + <property name="offCommentFormat" > value="CHECKSTYLE.OFF\:([\w\|]+)"/> > + <property name="onCommentFormat" > value="CHECKSTYLE.ON\:([\w\|]+)"/> > + <property name="checkFormat" value="$1"/> > + </module> > <module name="SuppressWarningsHolder" /> > </module> > - <module name="SuppressionCommentFilter"> > - <property name="offCommentFormat" value="CHECKSTYLE\:OFF"/> > - <property name="onCommentFormat" value="CHECKSTYLE\:ON"/> > - </module> > - <module name="SuppressionCommentFilter"> > - <property name="offCommentFormat" value="CHECKSTYLE.OFF\:([\w\|]+)"/> > - <property name="onCommentFormat" value="CHECKSTYLE.ON\:([\w\|]+)"/> > - <property name="checkFormat" value="$1"/> > - </module> > <module name="SuppressWarningsFilter"/> > <!-- Header checks --> > <module name="Header"> > > -- > To stop receiving notification emails like this one, please contact > ['"[email protected]" <[email protected]>'].
