reta commented on issue #367: [CXF-7608] Propagate trace ids as it lets log correlation to be consi? URL: https://github.com/apache/cxf/pull/367#issuecomment-358162063 @aldex32 absolutely, here is the test case I have in mind: ``` @Test public void testThatNoSpansAreRecordedWnenNotSampled() { final Tracing never = Tracing .newBuilder() .reporter(new TestSpanReporter()) .sampler(Sampler.NEVER_SAMPLE) .build(); final Response r = createWebClient("/bookstore/books", new BraveClientProvider(never)).get(); assertEquals(Status.OK.getStatusCode(), r.getStatus()); assertThat(TestSpanReporter.getAllSpans().size(), equalTo(0)); assertThatTraceHeadersArePresent(r, false); } ``` If we run it against the current master, it will fail and still record some spans. However, with your fix the trace / spans are correctly applying the sampler rules (in this case - never sampler) and nothing is being recorded. Please let me know if it makes sense to you. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
