reta commented on a change in pull request #369: [CXF-7610] - Adding SPI to 
handle customizations to the server bean.
URL: https://github.com/apache/cxf/pull/369#discussion_r162787024
 
 

 ##########
 File path: rt/rs/sse/src/main/resources/META-INF/beans.xml
 ##########
 @@ -2,5 +2,5 @@
 <beans xmlns="http://java.sun.com/xml/ns/javaee";
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
        xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
http://xmlns.jcp.org/xml/ns/javaee/beans_1_1.xsd";
-       bean-discovery-mode="all">
 
 Review comment:
   Agree than `all` was not correct here, but I would like SSE to be 
discoverable with no efforts when run in CDI container. I think we need only 
one single class to be discoverable , `SseFeature`, so @johnament could we add 
some exclusion / inclusion rules instead of just cutting everything off? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to