rmannibucau commented on a change in pull request #369: [CXF-7610] - Adding SPI
to handle customizations to the server bean.
URL: https://github.com/apache/cxf/pull/369#discussion_r162804746
##########
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ResourceUtils.java
##########
@@ -902,9 +904,18 @@ public static JAXRSServerFactoryBean
createApplication(Application app,
bean.getProperties(true).putAll(appProps);
}
bean.setApplication(app);
-
+ customize(bean);
return bean;
}
+
+ private static void customize(JAXRSServerFactoryBean bean) {
+ ServiceLoader<JAXRSServerFactoryCustomizationExtension> extensions
Review comment:
@johnament then ensure there is an OSGi test and it is deactivable through a
bus or factory property please (dont think it is in this PR, is it?). Goal is
to ensure the code is portable and not limited to MP which would dedeat the SPI
and that the module can be provided as a container service but not activated if
not desired in the app. Also opentracing is already integrated in brave alone
or cxf extension so probably doesnt need much SPI but more a wrapper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
