andymc12 opened a new pull request #373: JAX-RS 2.1 TCK issues
URL: https://github.com/apache/cxf/pull/373
 
 
   In testing the JAX-RS 2.1 TCK, we've found a few issues:
   1) The `Headers.toHttpLanguage(...)` method will return things like "en-" in 
some cases - I believe this is because there is an empty (but non-null) country 
passed in as part of the Locale.  This seems like an error condition to me, but 
it seems to be tested by the TCK, so the fix is pretty simple - just checking 
whether the country is non-empty rather than just non-null.
   2) The javadoc for `Invocation.Builder.headers(...)` method says that when 
called, all pre-existing headers must be removed.  Currently, we're just adding 
the new headers, but not removing the old ones.  
   
   I provided test cases for these conditions, but I won't have confirmation 
that these fixes actually pass the TCK until tomorrow, but I wanted to get the 
PR out now to ensure that the fixes get into the 3.2.2 release.  If the fixes 
are unsuccessful, I'll abort this PR and try again after 3.2.2 is released.  If 
they are successful (and assuming no glaring issues uncovered during review), 
then I'll plan to merge ASAP.
   
   Thanks, Andy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to