Feel free to raise an issue on JIRA and a PR. Personally, I'd like for the javax.servlet stuff to remain, so maybe we make this configuration driven instead.
On Mon, Feb 12, 2018 at 9:42 AM Romain Manni-Bucau <[email protected]> wrote: > side note: temporary work around which makes 3.2.2 usable directly: > > InjectionUtils.STANDARD_CONTEXT_CLASSES.removeIf(s -> > s.startsWith("javax.servlet.")); > > > > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github < > https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > 2018-02-06 21:07 GMT+01:00 Romain Manni-Bucau <[email protected]>: > > > Mainly but I strongly think cxf shouldnt assume it can own default. At > > least we should observe beans to skip the add if already here and have a > > bus property to fully skip it - or extension event to configure jaxrs > > extension. > > > > Le 6 févr. 2018 20:53, "John D. Ament" <[email protected]> a écrit : > > > >> So then your issue is simply the javax.servlet ones, right? > >> > >> On Tue, Feb 6, 2018 at 2:14 PM Romain Manni-Bucau < > [email protected]> > >> wrote: > >> > >> > Le 6 févr. 2018 20:07, "John D. Ament" <[email protected]> a > écrit > >> : > >> > > >> > If we remove @Default then it won't be injectable without > >> > @ContextResolved. Are you seeing an issue though? > >> > > >> > > >> > Yes. Owb-web provides all servlet beans so it leads to ambiguous > >> > resolution. > >> > > >> > Also not being in the spec it must use a custom classifier imo - think > >> of > >> > request issue deltaspike had cause of that. > >> > > >> > Min is to toggle them off by default and probably another toggle for > >> other > >> > context types. Typically meecrowave supports context injection without > >> > @Inject (as in the spec) so this just slows down the runtime for no > >> gain. > >> > > >> > Side note: vetoing conflicting bean doeznt work since in a container > cxf > >> > would be wrong more often than the built in bean. Think to a > >> > jaxrs/jsf/servlet app, the cdi container knows better how to inject > the > >> > request for instance - no need of cxf threadlocal which is not set by > >> jsf > >> > ;). > >> > > >> > > >> > > >> > On Tue, Feb 6, 2018 at 1:59 PM Romain Manni-Bucau < > >> [email protected]> > >> > wrote: > >> > > >> > > Cdi provides a servlet context, request etc... bean. With cxf > >> contextbean > >> > > it is now ambiguous and you cant use a cdi container with cxf. The > >> > default > >> > > qualifier must be dropped from that bean. > >> > > > >> > > Le 6 févr. 2018 19:57, "John D. Ament" <[email protected]> a > >> écrit > >> > : > >> > > > >> > > > Sorry don't really understand your response. > >> > > > > >> > > > On Tue, Feb 6, 2018 at 1:52 PM Romain Manni-Bucau < > >> > [email protected] > >> > > > > >> > > > wrote: > >> > > > > >> > > > > @Inject X x; should match not a single CXF injection but > >> > > > > ContextProducerBean matches @Default. Read too fast and though > it > >> was > >> > > > > @Context but just looks like @Default shouldnt be in the beans. > >> > > > > > >> > > > > > >> > > > > Romain Manni-Bucau > >> > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> > > > > <https://rmannibucau.metawerx.net/> | Old Blog > >> > > > > <http://rmannibucau.wordpress.com> | Github < > >> > > > > https://github.com/rmannibucau> | > >> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > >> > > > > < > >> > > > > https://www.packtpub.com/application-development/java- > >> > > > ee-8-high-performance > >> > > > > > > >> > > > > > >> > > > > 2018-02-06 19:50 GMT+01:00 John D. Ament <[email protected] > >: > >> > > > > > >> > > > > > On Tue, Feb 6, 2018 at 1:49 PM Romain Manni-Bucau < > >> > > > [email protected] > >> > > > > > > >> > > > > > wrote: > >> > > > > > > >> > > > > > > Hi guys, > >> > > > > > > > >> > > > > > > doesn't cdi integration of jaxrs miss a: > >> > > > > > > > >> > > > > > > bbd.addQualifier(Context.class); > >> > > > > > > > >> > > > > > > > >> > > > > > What class is that? > >> > > > > > > >> > > > > > > >> > > > > > > ? > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > Romain Manni-Bucau > >> > > > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> > > > > > > <https://rmannibucau.metawerx.net/> | Old Blog > >> > > > > > > <http://rmannibucau.wordpress.com> | Github < > >> > > > > > > https://github.com/rmannibucau> | > >> > > > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > >> > > > > > > < > >> > > > > > > https://www.packtpub.com/application-development/java- > >> > > > > > ee-8-high-performance > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > >
