WhiteCat22 commented on a change in pull request #407: [CXF-7716] Reduce
StringBuilders and other performance changes.
URL: https://github.com/apache/cxf/pull/407#discussion_r183100561
##########
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/URITemplate.java
##########
@@ -130,10 +130,34 @@ public String getPatternValue() {
private static String escapeCharacters(String expression) {
- StringBuilder sb = new StringBuilder();
- for (int i = 0; i < expression.length(); i++) {
- char ch = expression.charAt(i);
- sb.append(isReservedCharacter(ch) ? "\\" + ch : ch);
+ int length = expression.length();
+ int i = 0;
+ char ch = ' ';
+ for (; i < length; ++i) {
+ ch = expression.charAt(i);
+ if (isReservedCharacter(ch)) {
+ break;
+ }
+ }
+
+ if (i == length) {
+ return expression;
+ }
+
+ // Allows for up to 8 escaped characters before we start creating more
+ // StringBuilders. 8 is an arbitrary limit, but it seems to be
+ // sufficient in most cases.
+ StringBuilder sb = new StringBuilder(length + 8);
Review comment:
Apparently amending the file removes comments, but I added a comment
explaining why we add +8 to the length.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
