reta commented on a change in pull request #407: [CXF-7716] Reduce 
StringBuilders and other performance changes.
URL: https://github.com/apache/cxf/pull/407#discussion_r183259135
 
 

 ##########
 File path: 
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
 ##########
 @@ -1508,11 +1509,40 @@ public static boolean matchMimeTypes(MediaType 
requestContentType,
                 }
             }
         }
-
         return new ArrayList<>(supportedMimeTypeList);
+    }
+
+    public static boolean doMimeTypesIntersect(List<MediaType> 
requiredMediaTypes, List<MediaType> userMediaTypes) {
+        for (MediaType requiredType : requiredMediaTypes) {
 
 Review comment:
   Regarding this part, I understand the purpose, but now there 2 identical 
places, `intersectMimeTypes` and `doMimeTypesIntersect`, with the same code 
(solving one problem but introducing another). What I am thinking about is to 
introduce some kind of accumulator to either map the result of the operation to 
the `List` or `true/false`, do you think it would be possible @WhiteCat22 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to