dkulp commented on a change in pull request #414: [CXF-7653]:Fix NPE in
ClientProxy
URL: https://github.com/apache/cxf/pull/414#discussion_r185790182
##########
File path: core/src/main/java/org/apache/cxf/endpoint/ClientImpl.java
##########
@@ -657,24 +657,9 @@ private void enrichFault(Fault fault) {
if (ex != null) {
throw ex;
}
-
- if (resList == null
- && oi != null && !oi.getOperationInfo().isOneWay()) {
-
- BindingOperationInfo boi = oi;
- if (boi.isUnwrapped()) {
- boi = boi.getWrappedOperation();
- }
- if (!boi.getOutput().getMessageParts().isEmpty()) {
- //we were supposed to get some output, but didn't
- throw new IllegalStateException("Response message did not
contain proper response data. Expected: "
- +
boi.getOutput().getMessageParts().get(0).getConcreteName());
- }
- }
Review comment:
Why is all this code removed? If the WSDL states that there should be a
response and there isn't, an exception should be thrown. The above is correct.
By pushing some of this down into the ClientProxy's, anything that doesn't
use the client proxies (like Camel endpoints) wouldn't have this check in place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
