amarkevich commented on a change in pull request #481: CXF-7923 String.split
via fastpath instead of precompiled Pattern
URL: https://github.com/apache/cxf/pull/481#discussion_r239790887
##########
File path: core/src/main/java/org/apache/cxf/common/util/PackageUtils.java
##########
@@ -57,7 +58,7 @@ public static String getSharedPackageName(List<Class<?>>
classes) {
List<String> currentParts = new ArrayList<>();
for (Class<?> cls : classes) {
if (!Proxy.isProxyClass(cls)) {
- lParts.add(StringUtils.getParts(getPackageName(cls), "\\."));
+ lParts.add(Arrays.asList(getPackageName(cls).split("\\.")));
Review comment:
PackageUtils: 'A package name must not contain two consecutive dots'
(Eclipse validation)
AbstractHTTPDestination: according to [1] only single space character
accepted
1. https://tools.ietf.org/html/rfc1945#section-11.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
