reta commented on a change in pull request #482: [CXF-7926] Initial MP Rest
Client 1.2 impl
URL: https://github.com/apache/cxf/pull/482#discussion_r241993426
##########
File path:
rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/MicroProfileClientFactoryBean.java
##########
@@ -97,13 +98,16 @@ protected void initClient(AbstractClient client, Endpoint
ep, boolean addHeaders
@Override
protected ClientProxyImpl createClientProxy(ClassResourceInfo cri, boolean
isRoot,
ClientState actualState,
Object[] varValues) {
+ CDIInterceptorWrapper interceptorWrapper =
CDIInterceptorWrapper.createWrapper(getServiceClass());
+ MicroProfileClientProxyImpl impl;
if (actualState == null) {
- return new MicroProfileClientProxyImpl(URI.create(getAddress()),
proxyLoader, cri, isRoot,
- inheritHeaders, executorService, configuration, varValues);
+ impl = new MicroProfileClientProxyImpl(URI.create(getAddress()),
proxyLoader, cri, isRoot,
Review comment:
I think the variant with `return` statements was more readable and
straightforward, just an opinion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
