BassExtractor commented on a change in pull request #462: Httpsig
URL: https://github.com/apache/cxf/pull/462#discussion_r246274789
##########
File path:
rt/rs/security/http-signature/src/main/java/org/apache/cxf/rs/security/httpsignature/SignatureException.java
##########
@@ -0,0 +1,7 @@
+package org.apache.cxf.rs.security.httpsignature;
+
+public class SignatureException extends RuntimeException {
+ public SignatureException(String message) {
Review comment:
I agree, we can remove the nullchecks and rather have an exception
description on javadoc. Do you have suggestions for which exception that should
be thrown?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services