reta commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r246483627
########## File path: rt/rs/security/http-signature/src/main/java/org/apache/cxf/rs/security/httpsignature/TomitribeSignatureValidator.java ########## @@ -0,0 +1,96 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.cxf.rs.security.httpsignature; + +import java.security.Key; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.logging.Logger; + +import org.apache.cxf.common.logging.LogUtils; +import org.apache.cxf.rs.security.httpsignature.exception.DifferentAlgorithmsException; +import org.apache.cxf.rs.security.httpsignature.exception.InvalidDataToVerifySignatureException; +import org.apache.cxf.rs.security.httpsignature.exception.InvalidSignatureException; +import org.apache.cxf.rs.security.httpsignature.exception.InvalidSignatureHeaderException; +import org.apache.cxf.rs.security.httpsignature.provider.AlgorithmProvider; +import org.apache.cxf.rs.security.httpsignature.provider.PublicKeyProvider; +import org.apache.cxf.rs.security.httpsignature.provider.SecurityProvider; +import org.apache.cxf.rs.security.httpsignature.utils.SignatureHeaderUtils; +import org.tomitribe.auth.signatures.Signature; +import org.tomitribe.auth.signatures.Verifier; + +public final class TomitribeSignatureValidator implements SignatureValidator { + private static final Logger LOG = LogUtils.getL7dLogger(TomitribeSignatureValidator.class); + + @Override + public void validate(Map<String, List<String>> messageHeaders, + AlgorithmProvider algorithmProvider, + PublicKeyProvider publicKeyProvider, + SecurityProvider securityProvider, + String method, + String uri) { + Signature signature = extractSignatureFromHeader(messageHeaders.get("Signature").get(0)); + + String providedAlgorithm = algorithmProvider.getAlgorithmName(signature.getKeyId()); + Objects.requireNonNull(providedAlgorithm, "provided algorithm is null"); Review comment: Not needed anymore, `getAlgorithmName` will never return `null` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
