jwcarman commented on issue #507: CXF-7957: Swagger2Feature Doesn't Work With Swagger Versions Above 1.… URL: https://github.com/apache/cxf/pull/507#issuecomment-459119271 I’m fine with it. Was just explaining my motivation. I’ll update when I get back home later. On Wed, Jan 30, 2019 at 4:34 PM Andriy Redko <notificati...@github.com> wrote: > *@reta* commented on this pull request. > ------------------------------ > > In > rt/rs/description-swagger/src/main/java/org/apache/cxf/jaxrs/swagger/openapi/SwaggerToOpenApiConversionFilter.java > <https://github.com/apache/cxf/pull/507#discussion_r252446880>: > > > @@ -55,7 +57,8 @@ public void filter(ContainerRequestContext reqCtx) throws IOException { > @Override > public void filter(ContainerRequestContext reqCtx, ContainerResponseContext respCtx) throws IOException { > if (Boolean.TRUE == reqCtx.getProperty(OPEN_API_PROPERTY)) { > - String swaggerJson = (String)respCtx.getEntity(); > + String swaggerJson = respCtx.getEntity() instanceof String ? (String)respCtx.getEntity() > > It is exactly the same: the mapper does nothing for String (returns the > same string back) but convert to JSON any object (same is done with ?:) > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/cxf/pull/507#discussion_r252446880>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAVP-46_b9VzWJ-qQeNAWBaWHZg-tlnjks5vIg_ngaJpZM4aaPyn> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
