shadrin-nv commented on a change in pull request #514: Configure media types in
bean for logging intercepters
URL: https://github.com/apache/cxf/pull/514#discussion_r259213512
##########
File path:
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/DefaultLogEventMapper.java
##########
@@ -46,17 +44,25 @@
import org.apache.cxf.ws.addressing.ContextUtils;
public class DefaultLogEventMapper {
- private static final Set<String> BINARY_CONTENT_MEDIA_TYPES;
+ private static final Set<String> DEFAULT_BINARY_CONTENT_MEDIA_TYPES;
Review comment:
Logically, we don’t need this set at all as a separate instance.
I propose to abandon it. And configure only the editable set at once.
public DefaultLogEventMapper() {
binaryContentMediaTypes.add("application/octet-stream");
binaryContentMediaTypes.add("application/pdf");
binaryContentMediaTypes.add("image/png");
binaryContentMediaTypes.add("image/jpeg");
binaryContentMediaTypes.add("image/gif");
}
What do you think? Would that be more correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
