dkulp commented on a change in pull request #532: handle WstxLazyException for
pretty logging
URL: https://github.com/apache/cxf/pull/532#discussion_r270871510
##########
File path:
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/PrettyLoggingFilter.java
##########
@@ -77,9 +78,9 @@ private String getPrettyMessage(LogEvent event) {
try {
StaxUtils.copy(xreader, xwriter);
xwriter.flush();
- } catch (XMLStreamException xse) {
+ } catch (XMLStreamException | WstxLazyException e) {
Review comment:
This would put a hard dependency on woodstox in the logging module. I
believe the better option would be to catch RuntimeException and check the
cause to see if the cause is a XMLStreamException. If not, rethrow the
RuntimeException, otherwise treat it like the XMLStreamException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
