reta commented on issue #529: CXF-8009: CXF should not rely on ClassUtils for 
CGLIB proxy checks
URL: https://github.com/apache/cxf/pull/529#issuecomment-478806954
 
 
   Hi @rmannibucau ,
   
   Thanks a lot for the review, yeah indeed this is pretty old class, purely 
Spring-specific. I remember we have discussed this awhile back, when 
`ClassUnwrapper` / `CdiClassUnwraper` were introduced. Agree that the 
responsibilities are now half-splitted between `ClassHelper` and 
`ClassUnwrapper`. 
   
   I think we could do:
   1) Convert `SpringAopClassHelper` into `SpringClassUnwrapper` (we would need 
to add a method
   `getRealClassFromClass` to `ClassUnwrapper` to handle the case when instance 
is not available).
   2) Make `SpringClassUnwrapper` logic based on list of predicates with 
defaults provided (to behave like `SpringAopClassHelper` at least)
   
   Did I get your idea right? Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to