coheigea commented on a change in pull request #588: CXF-8129 - Update to 
Woodstox 6.0.x
URL: https://github.com/apache/cxf/pull/588#discussion_r335022781
 
 

 ##########
 File path: core/pom.xml
 ##########
 @@ -189,18 +189,6 @@
             <scope>provided</scope>
             <optional>true</optional>
         </dependency>
-        <dependency>
 
 Review comment:
   Hi @reta, the reason I changed that was in our W3CMultiSchemaFactory, the 
call to Woodstox's W3CGrammar class now takes the shaded class name as a 
parameter. Actually the source uses the msv class, but it seems to be modified 
to use the shaded version in the final jar:
   
   
https://github.com/FasterXML/woodstox/blob/bae0330b0c2895b4aeb35ac83aa961d7f29bfa66/src/main/java/com/ctc/wstx/msv/W3CSchema.java
   
   So I had no option other than to use the shaded version with W3CGrammar, and 
after this there was no need of the msv dependency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to