reta commented on a change in pull request #603: [CXF-8161] fix memory leak and
thread leak in JMSDestination
URL: https://github.com/apache/cxf/pull/603#discussion_r349884363
##########
File path:
rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/JMSDestination.java
##########
@@ -174,9 +174,9 @@ public void onException(JMSException exception) {
}
}
- protected void restartConnection() {
+ protected synchronized void restartConnection() {
Review comment:
Sorry for delayed response @steingebein, I think you are right, no risk of
deadlock, just tons of blocked threads, did some tests to verify that, we
should be "safe" there. The `synchronized` would indeed help there.
I was trying to reconstruct the flows, and came to the same conclusions as
you: the code is quite complicated and fragile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
