reta commented on issue #603: [CXF-8161] fix memory leak and thread leak in JMSDestination URL: https://github.com/apache/cxf/pull/603#issuecomment-565734414 hey @steingebein, thanks a lot for the great work, I did two post-merge changes: - put back `running = false;`, so the polling threads would stop progressing, I believe this make sense - refactored your test case to use test doubles as other tests from `JMSDestinationTest` suite (no mocks) Please let me know if you have any concerns or I missed something, thank you!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
