That sounds good. In that case, let's go ahead and plan to merge the TCK formparam fix (following Colm's review). If we get the other two reviewed (and possibly changed) by the end of the week, let's take them too, but no worries if not.
Thanks! Andy On Wed, Jan 8, 2020 at 11:57 AM Andrey Redko <[email protected]> wrote: > Hey Andy, > > I would finish up with SSE today, I was reading through the callback > discussion threads you mentioned, we may need to change a few things before > merge. The TCK formparam fixes look good to me, but I haven't dug into the > cause to be honest, Colm if you could take a look would be awesome, +1 from > me to merge. For CDI one I would appreciate to have some time to finish the > review, thanks! > > Best Regards, > Andriy Redko > > On Wed, Jan 8, 2020, 12:35 PM Colm O hEigeartaigh <[email protected]> > wrote: > >> No objections from me for including them, if Andriy is happy with them. >> Otherwise we can leave them for 3.3.6. >> >> Colm. >> >> On Wed, Jan 8, 2020 at 5:19 PM Andy McCright <[email protected]> >> wrote: >> >>> Andriy, Colm, >>> >>> I've three pull requests in progress that we could pull in - I'd like to >>> get some more reviews on them, but otherwise I think they are ready to >>> merge. That said, I'm fine with waiting until the next release too. The >>> PRs in question are: >>> https://github.com/apache/cxf/pull/619 - Adding injection into MP Rest >>> Client's ClientHeadersFactory - this will be part of the next MP spec (not >>> yet released), thus no urgency, but still a nice feature. >>> https://github.com/apache/cxf/pull/621 - fixes some Jakarta EE JAX-RS >>> TCK failures in the SSE bucket. >>> https://github.com/apache/cxf/pull/620 - fixes some Jakarta EE JAX-RS >>> TCK failures related to FormParam processing. >>> >>> Do you want to include them in the 3.3.5? >>> >>> Thanks, Andy >>> >>> On Wed, Jan 8, 2020 at 9:49 AM Colm O hEigeartaigh <[email protected]> >>> wrote: >>> >>>> OK thanks Freeman. As of this point I'm all done with the release. >>>> @Andriy >>>> Redko <[email protected]> please reply when you're finished with any >>>> changes >>>> and we can start the votes. >>>> >>>> Colm. >>>> >>>> On Wed, Jan 8, 2020 at 3:00 PM ffang <[email protected]> wrote: >>>> >>>> > >>>> > >>>> > > On Jan 6, 2020, at 1:16 PM, Colm O hEigeartaigh < >>>> [email protected]> >>>> > wrote: >>>> > > >>>> > > Hi all, >>>> > > >>>> > > It would be good to get votes started on new 3.3 + 3.2 releases by >>>> the >>>> > end of this week, as we are already overdue. We already have 32 JIRAs >>>> fixed >>>> > for 3.3.5, so it's shaping up to be a pretty big release! >>>> > > >>>> > > There are 2 remaining JIRA issues targetted for 3.3.5, both >>>> assigned to >>>> > Freeman. @Freeman Fang <mailto:[email protected]> do you think >>>> you >>>> > have time to look at them? Otherwise they can be moved to 3.3.6. >>>> > Hi Colm, >>>> > >>>> > Both CXF-8173 and CXF-8183 are same issue, they are harmless in terms >>>> of >>>> > function at this stage and we can revisit in the future. >>>> > Btw, I added comment here to explain it a bit >>>> > >>>> > >>>> > >>>> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739 >>>> > < >>>> > >>>> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739 >>>> > > >>>> > >>>> > Best Regards >>>> > Freeman >>>> > > >>>> > > On my todo list is: >>>> > > - Merge https://github.com/apache/cxf/pull/615 < >>>> > https://github.com/apache/cxf/pull/615> >>>> > > - Update XML Schema (currently under vote) >>>> > > - Merge a fix for the regression introduced by CXF-8088. >>>> > > >>>> > > Colm. >>>> > > >>>> > >>>> > >>>> >>>
