[GitHub] [cxf] reta commented on a change in pull request #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0

[GitBox]

reta commented on a change in pull request #657: [CXF-8151] Upgrade to Bean 
Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#discussion_r405214903
 
 

 ##########
 File path: osgi/karaf/features/src/main/resources/features.xml
 ##########
 @@ -314,7 +314,7 @@
         <bundle 
start-level="35">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger-ui/${project.version}</bundle>
         <bundle 
start-level="40">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger/${project.version}</bundle>
         <bundle start-level="35" 
dependency="true">mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${cxf.jackson.version}</bundle>
-        <bundle start-level="10" 
dependency="true">mvn:jakarta.validation/jakarta.validation-api/${cxf.validation.api.version}</bundle>
+        <bundle start-level="10" 
dependency="true">mvn:javax.validation/validation-api/1.1.0.Final</bundle>
 
 Review comment:
   @amarkevich It would be better to override manifest instead, 
   ```
   <bundle start-level="10" 
dependency="true">mvn:jakarta.validation/jakarta.validation-api/${cxf.validation.api.version}$overwrite=merge&amp;javax.validation.constraints;version="[1.1,3)"</bundle>
   ```
   I have sent the PR against 1.6.x branch as well 
(https://github.com/swagger-api/swagger-core/pull/3497) but it may take some 
time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services