shark300 commented on a change in pull request #642: [CXF-8213] Add Micrometer metric support for JAX-WS URL: https://github.com/apache/cxf/pull/642#discussion_r407228099
########## File path: integration/spring-boot/autoconfigure/src/test/java/org/apache/cxf/spring/boot/autoconfigure/micrometer/provider/jaxws/CustomTimed.java ########## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.cxf.spring.boot.autoconfigure.micrometer.provider.jaxws; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Inherited; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +import org.springframework.core.annotation.AliasFor; + +import io.micrometer.core.annotation.Timed; + +@Target({ElementType.ANNOTATION_TYPE, ElementType.TYPE, ElementType.METHOD}) +@Retention(RetentionPolicy.RUNTIME) +@Inherited +@Timed +public @interface CustomTimed { Review comment: This annotation helps to test meta annotations. The Spring's AnnotationCollector finds this annotations too. I didn't want to reduce feature set of original Spring implementation. Unfortunately, there is a special annotation in Spring (AliasFor) but I don't want to implement this kind of feature because it's Spring specific. Due to this one, there are two CustomeTimed annotation (one for Spring, and one for CXF provider tests) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
