andymc12 commented on a change in pull request #680:
URL: https://github.com/apache/cxf/pull/680#discussion_r441840909
##########
File path:
rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/MicroProfileClientConfigurableImpl.java
##########
@@ -42,6 +43,8 @@
MessageBodyWriter.class, MessageBodyReader.class,
ResponseExceptionMapper.class};
private static final String CONFIG_KEY_DISABLE_MAPPER =
"microprofile.rest.client.disable.default.mapper";
+ private Instantiator instantiator =
CDIFacade.getInstantiator().orElse(super.getInstantiator());
Review comment:
I think it is a good idea, but when I tried it out, I realized that it
breaks one of the TCK test cases - it fails when a new client is built using
the `RestClientBuilder` from within a CDI-managed bean - specifically,[ this
test](https://github.com/eclipse/microprofile-rest-client/blob/24096f2df248938fc00185a587bc812d969b5845/tck/src/main/java/org/eclipse/microprofile/rest/client/tck/cditests/CDIManagedProviderTest.java#L91).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
