coheigea commented on a change in pull request #681:
URL: https://github.com/apache/cxf/pull/681#discussion_r450965523
##########
File path:
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/AbstractLoggingInterceptor.java
##########
@@ -102,8 +115,13 @@ public void createExchangeId(Message message) {
}
}
- protected String transform(final String originalLogString) {
+ protected String transform(final Message message, final String
originalLogString) {
return originalLogString;
}
+ protected String maskSensitiveElements(final Message message, String
originalLogString) {
+ return Optional.of(maskSensitiveHelper)
Review comment:
Why Optional here when maskSensitiveHelper is declared as final?
##########
File path:
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/AbstractLoggingInterceptor.java
##########
@@ -73,6 +78,14 @@ public long getInMemThreshold() {
return threshold;
}
+ public void addSensitiveElementNames(final List<String>
sensitiveElementNames) {
+ maskSensitiveHelper.addSensitiveElementNames(sensitiveElementNames);
+ }
+
+ public void addSensitiveHeaders(final List<String> sensitiveHeaders) {
Review comment:
Maybe rename to HTTPHeaders to make the meaning clear (as opposed to say
SOAP headers)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
