shark300 commented on a change in pull request #642: URL: https://github.com/apache/cxf/pull/642#discussion_r508063120
########## File path: integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/micrometer/MicrometerMetricsAutoConfiguration.java ########## @@ -0,0 +1,144 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cxf.spring.boot.autoconfigure.micrometer; + +import java.util.List; + +import org.apache.cxf.jaxws.JaxWsServerFactoryBean; +import org.apache.cxf.metrics.MetricsProvider; +import org.apache.cxf.metrics.micrometer.MicrometerMetricsProperties; +import org.apache.cxf.metrics.micrometer.MicrometerMetricsProvider; +import org.apache.cxf.metrics.micrometer.provider.DefaultExceptionClassProvider; +import org.apache.cxf.metrics.micrometer.provider.ExceptionClassProvider; +import org.apache.cxf.metrics.micrometer.provider.StandardTags; +import org.apache.cxf.metrics.micrometer.provider.StandardTagsProvider; +import org.apache.cxf.metrics.micrometer.provider.TagsCustomizer; +import org.apache.cxf.metrics.micrometer.provider.TagsProvider; +import org.apache.cxf.metrics.micrometer.provider.TimedAnnotationProvider; +import org.apache.cxf.metrics.micrometer.provider.jaxws.JaxwsFaultCodeProvider; +import org.apache.cxf.metrics.micrometer.provider.jaxws.JaxwsFaultCodeTagsCustomizer; +import org.apache.cxf.metrics.micrometer.provider.jaxws.JaxwsOperationTagsCustomizer; +import org.apache.cxf.metrics.micrometer.provider.jaxws.JaxwsTags; +import org.apache.cxf.spring.boot.autoconfigure.CxfProperties; +import org.apache.cxf.spring.boot.autoconfigure.CxfProperties.Metrics.Server; +import org.apache.cxf.spring.boot.autoconfigure.micrometer.provider.SpringBasedTimedAnnotationProvider; +import org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration; +import org.springframework.boot.actuate.autoconfigure.metrics.OnlyOnceLoggingDenyMeterFilter; +import org.springframework.boot.actuate.autoconfigure.metrics.export.simple.SimpleMetricsExportAutoConfiguration; +import org.springframework.boot.autoconfigure.AutoConfigureAfter; +import org.springframework.boot.autoconfigure.condition.ConditionalOnBean; +import org.springframework.boot.autoconfigure.condition.ConditionalOnClass; +import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean; +import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication; +import org.springframework.boot.context.properties.EnableConfigurationProperties; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.core.annotation.Order; + +import io.micrometer.core.instrument.MeterRegistry; +import io.micrometer.core.instrument.config.MeterFilter; + +@Configuration +@AutoConfigureAfter({MetricsAutoConfiguration.class, SimpleMetricsExportAutoConfiguration.class}) +@ConditionalOnWebApplication(type = ConditionalOnWebApplication.Type.SERVLET) +@ConditionalOnClass({JaxWsServerFactoryBean.class, MetricsProvider.class}) +@ConditionalOnBean({MeterRegistry.class}) +@EnableConfigurationProperties(CxfProperties.class) +public class MicrometerMetricsAutoConfiguration { + + private final CxfProperties properties; + + public MicrometerMetricsAutoConfiguration(CxfProperties properties) { + this.properties = properties; + } + + @Bean + public TimedAnnotationProvider timedAnnotationProvider() { + return new SpringBasedTimedAnnotationProvider(); + } + + @Bean + public JaxwsTags jaxwsTags() { + return new JaxwsTags(); + } + + @Bean + @ConditionalOnMissingBean(ExceptionClassProvider.class) + public ExceptionClassProvider exceptionClassProvider() { + return new DefaultExceptionClassProvider(); + } + + @Bean + @ConditionalOnMissingBean(JaxwsFaultCodeProvider.class) + public JaxwsFaultCodeProvider jaxwsFaultCodeProvider() { + return new JaxwsFaultCodeProvider(); + } + + @Bean + @ConditionalOnMissingBean(JaxwsFaultCodeTagsCustomizer.class) + public JaxwsFaultCodeTagsCustomizer jaxwsFaultCodeTagsCustomizer(JaxwsTags jaxwsTags, + JaxwsFaultCodeProvider jaxwsFaultCodeProvider) { + return new JaxwsFaultCodeTagsCustomizer(jaxwsTags, jaxwsFaultCodeProvider); + } + + @Bean + @ConditionalOnMissingBean(JaxwsOperationTagsCustomizer.class) + public JaxwsOperationTagsCustomizer jaxwsOperationTagsCustomizer(JaxwsTags jaxwsTags) { + return new JaxwsOperationTagsCustomizer(jaxwsTags); + } + + @Bean + @ConditionalOnMissingBean(StandardTags.class) + public StandardTags standardTags() { + return new StandardTags(); + } + + @Bean + @ConditionalOnMissingBean(TagsProvider.class) + public TagsProvider tagsProvider(ExceptionClassProvider exceptionClassProvider, StandardTags standardTags) { + return new StandardTagsProvider(exceptionClassProvider, standardTags); + } + + @Bean + @ConditionalOnMissingBean(MetricsProvider.class) + public MetricsProvider metricsProvider(TagsProvider tagsProvider, + List<TagsCustomizer> tagsCustomizers, + TimedAnnotationProvider timedAnnotationProvider, + MeterRegistry registry) { + MicrometerMetricsProperties micrometerMetricsProperties = new MicrometerMetricsProperties(); + + Server server = this.properties.getMetrics().getServer(); + micrometerMetricsProperties.setAutoTimeRequests(server.isAutoTimeRequests()); + micrometerMetricsProperties.setRequestsMetricName(server.getRequestsMetricName()); + + return new MicrometerMetricsProvider(registry, tagsProvider, tagsCustomizers, timedAnnotationProvider, + micrometerMetricsProperties); + } + + @Bean + @Order(0) + public MeterFilter metricsSoapServerUriTagFilter() { Review comment: I rename it to `cxfMetricsMaxAllowedServerUriTagsFilter` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
