reta commented on a change in pull request #721: URL: https://github.com/apache/cxf/pull/721#discussion_r526515828
########## File path: rt/wsdl/src/main/java/org/apache/cxf/wsdl/ExtensionClassLoader.java ########## @@ -0,0 +1,38 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cxf.wsdl; + +import javax.xml.namespace.QName; + +import org.apache.cxf.common.classloader.ClassLoaderUtils; + +public class ExtensionClassLoader implements ExtensionClassCreator { + + public ExtensionClassLoader() { + } + @Override + public Class<?> createExtensionClass(Class<?> cls, QName qname, ClassLoader loader) { + try { + return ClassLoaderUtils.loadClass(cls.getName() + "Extensibility", ExtensionClassLoader.class); + } catch (ClassNotFoundException e) { Review comment: Probably we should log the exception here (debug or trace), just to help with troubleshooting ########## File path: core/src/main/java/org/apache/cxf/common/spi/GeneratedNamespaceClassLoader.java ########## @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cxf.common.spi; + +import java.util.Map; + +import org.apache.cxf.common.classloader.ClassLoaderUtils; + +public class GeneratedNamespaceClassLoader implements NamespaceClassCreator { + GeneratedNamespaceClassLoader() { + } + public synchronized Class<?> createNamespaceWrapper(Class<?> mcls, Map<String, String> map) { + String postFix = ""; + + if (mcls.getName().contains("eclipse")) { + try { + return ClassLoaderUtils.loadClass("org.apache.cxf.jaxb.EclipseNamespaceMapper", + GeneratedNamespaceClassLoader.class); + } catch (ClassNotFoundException e) { Review comment: Probably we should log the exception here (debug or trace), just to help with troubleshooting ########## File path: core/src/main/java/org/apache/cxf/common/spi/GeneratedNamespaceClassLoader.java ########## @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cxf.common.spi; + +import java.util.Map; + +import org.apache.cxf.common.classloader.ClassLoaderUtils; + +public class GeneratedNamespaceClassLoader implements NamespaceClassCreator { + GeneratedNamespaceClassLoader() { + } + public synchronized Class<?> createNamespaceWrapper(Class<?> mcls, Map<String, String> map) { + String postFix = ""; + + if (mcls.getName().contains("eclipse")) { + try { + return ClassLoaderUtils.loadClass("org.apache.cxf.jaxb.EclipseNamespaceMapper", + GeneratedNamespaceClassLoader.class); + } catch (ClassNotFoundException e) { + } + } else if (mcls.getName().contains(".internal")) { + postFix = "Internal"; + } else if (mcls.getName().contains("com.sun")) { + postFix = "RI"; + } + try { + return ClassLoaderUtils.loadClass("org.apache.cxf.jaxb.NamespaceMapper" + postFix, + GeneratedNamespaceClassLoader.class); + } catch (ClassNotFoundException e) { Review comment: Probably we should log the exception here (debug or trace), just to help with troubleshooting ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
