reta commented on a change in pull request #745:
URL: https://github.com/apache/cxf/pull/745#discussion_r576804816
##########
File path:
rt/frontend/simple/src/main/java/org/apache/cxf/endpoint/dynamic/DynamicClientFactory.java
##########
@@ -729,10 +729,10 @@ static void setupClasspath(StringBuilder classPath,
ClassLoader classLoader)
private URL composeUrl(String s) {
try {
- URIResolver resolver = new URIResolver(null, s, getClass());
-
- if (resolver.isResolved()) {
- return resolver.getURI().toURL();
+ try (URIResolver resolver = new URIResolver(null, s, getClass())) {
Review comment:
This one is a bit tricky since the `ServiceConstructionException` has to
be thrown if URI is not resolved and not throwing any exceptions. I refactored
it, please let me know what do you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
