Andrily, will do that in case there are unit tests affected/added because of CI failure or other reasons. The static analysis, I will start with minor and there will be very tiny changes for classes so it is easier to make one commit with many changes into the PR https://github.com/apache/cxf/pull/755
Regards, Alan On 2021/03/10 23:55:34, Andriy Redko <[email protected]> wrote: > Hi Alan, > > I think it is better to create new tickets and include the affected / added > test cases into the description as we go along. I would be easier to track > the changes. Thank you. > > Best Regards, > Andriy Redko > > Wednesday, March 10, 2021, 2:24:06 PM, you wrote: > > AM> Andriy, > AM> Many thanks for the feedback. I will start to focus on the area you > mentioned below. > AM> I wonder, shall we base the changes on the existing poll which is > referenced to a Jira CXF-8432 or it would be better to open a new Jira (new > pull) to address the feedback below. > > AM> On 2021/03/10 01:34:26, Andriy Redko <[email protected]> wrote: > >> Hello Alan, > > >> Thank you for offering your help and filling the CXF test gaps. With > >> respect to the PR [1], > >> there are some CI checks failing, could you please address those? With > >> respect to areas of improvement, > >> please check Sonar [2], it should give you some insights from statis > >> analysis. Thank you > > >> [1] https://github.com/apache/cxf/pull/755 > >> [2] https://sonarcloud.io/dashboard?id=cxf > > >> Best Regards, > >> Andriy Redko > > >> AM> Dear All > >> AM> In relation to this pull https://github.com/apache/cxf/pull/755 which > >> is related to this created issue by me > >> AM> https://issues.apache.org/jira/browse/CXF-8432 > > >> AM> It would be nice if I can get some feedback about some classes which > >> needs more unit test cover. > >> AM> Otherwise, I will go ahead and add more unit test methods for existing > >> classes or some classes which I see in need a Unit Test class. > >> AM> Having said that, it would be much better if I can get some feedback > >> or some suggestions which area or modules or classes that are in need to > >> have better unit test cover. > > >> AM> Thanks > >
