reta opened a new pull request #815:
URL: https://github.com/apache/cxf/pull/815


   The `org.apache.cxf.jaxrs.client.logging.RESTLoggingTest.testBinary` 
occasionally fails on Jenkins with:
   
   ```
   org.junit.ComparisonFailure: expected:<[--- Content suppressed ---]> but 
was:<&amp#1;&amp#2;&amp#3;&amp#4;&amp#5;&amp#6;&amp#8;> at 
org.apache.cxf.jaxrs.client.logging.RESTLoggingTest.assertContentNotLogged(RESTLoggingTest.java:121)
 at 
org.apache.cxf.jaxrs.client.logging.RESTLoggingTest.testBinary(RESTLoggingTest.java:83)
   ```
   
   It seems like the root cause is in-place `loggingFeature.setLogBinary(true)` 
modification: the feature's interceptors are called in the scope of different 
threads (execution thread + CXF's async working queue) but the feature was not 
supposed to be used from multiple threads. As such, the hypothesis is that 
`logBinary` flag change may not be visible by all threads. 
   
   The test case was split into 2: binary and non-binary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to