brevilo commented on a change in pull request #806:
URL: https://github.com/apache/cxf/pull/806#discussion_r663851365
##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -185,6 +185,26 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <configuration>
+ <instructions>
+
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
Review comment:
Sorry, I don't follow yet. Should I remove the properties from the main
POM you referenced? My original approach was meant to constrain the change's
impact to the POM in question only.
##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -185,6 +185,26 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <configuration>
+ <instructions>
+
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
Review comment:
Thanks @reta, I totally missed "(re)defined in
`microprofile-client/pom.xml`" before, hence my confusion.
Anyhow, your approach doesn't work. If I remove only `cxf.bundle.activator`
I get an exception that still involves `org.apache.cxf.bus.osgi.CXFActivator`.
If I also remove `cxf.export.service` the exception is gone but `MANIFEST.MF`
still contains `Bundle-ActivationPolicy: lazy` which is the root cause of the
problem I'm trying to solve here: lazy activation just doesn't work for
SPI/ServiceLoader.
Since Aries Blueprint is used I had a look at how it might deal with the
bundle activation policy. Unfortunately [that
part](https://aries.apache.org/documentation/modules/blueprint.html#_lazy_and_eager_activiation)
is missing from the documentation :-/ Any idea?
##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -185,6 +185,26 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <configuration>
+ <instructions>
+
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
Review comment:
Thanks @reta, I totally missed "(re)defined in
`microprofile-client/pom.xml`" before, hence my confusion.
Anyhow, your approach doesn't work. If I remove only `cxf.bundle.activator`
I get an exception that still involves `org.apache.cxf.bus.osgi.CXFActivator`.
If I also remove `cxf.export.service` the exception is gone but `MANIFEST.MF`
still contains `Bundle-ActivationPolicy: lazy` which is the root cause of the
problem I'm trying to solve here: lazy activation just doesn't work for
SPI/ServiceLoader.
Since Aries Blueprint is used I had a look at how it might deal with the
bundle activation policy. Unfortunately [that
part](https://aries.apache.org/documentation/modules/blueprint.html#_lazy_and_eager_activiation)
is missing from the documentation 😒 Any idea?
##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -185,6 +185,26 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <configuration>
+ <instructions>
+
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
Review comment:
Thanks @reta, I totally missed "(re)defined in
`microprofile-client/pom.xml`" before, hence my confusion.
Anyhow, your approach doesn't work. If I remove only `cxf.bundle.activator`
I get an exception that still involves `org.apache.cxf.bus.osgi.CXFActivator`.
If I also remove `cxf.export.service` the exception is gone but `MANIFEST.MF`
still contains `Bundle-ActivationPolicy: lazy` which is the root cause of the
problem I'm trying to solve here: [lazy
activation](https://github.com/apache/cxf/blob/master/parent/pom.xml#L652) just
doesn't work for SPI/ServiceLoader.
Since Aries Blueprint is used I had a look at how it might deal with the
bundle activation policy. Unfortunately [that
part](https://aries.apache.org/documentation/modules/blueprint.html#_lazy_and_eager_activiation)
is missing from the documentation 😒 Any idea?
##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -185,6 +185,26 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <configuration>
+ <instructions>
+
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
Review comment:
Thanks @reta, I totally missed "(re)defined in
`microprofile-client/pom.xml`" before, hence my confusion.
Anyhow, your approach doesn't work. If I remove only `cxf.bundle.activator`
I get an exception that still involves `org.apache.cxf.bus.osgi.CXFActivator`.
If I also remove `cxf.export.service` the exception is gone but `MANIFEST.MF`
still contains `Bundle-ActivationPolicy: lazy` which is the root cause of the
problem I'm trying to solve here: lazy activation just doesn't work for
SPI/ServiceLoader.
Since Aries Blueprint is used I had a look at how it might deal with the
bundle activation policy. Unfortunately [that
part](https://aries.apache.org/documentation/modules/blueprint.html#_lazy_and_eager_activiation)
is missing from the documentation 😒 Any idea?
OTOH, are you sure changing the two properties (and/or Blueprint) is the
right approach here? [Lazy
activation](https://github.com/apache/cxf/blob/master/parent/pom.xml#L652) is
explicitly defined in the parent POM, which is why I tried to "undefine"
(remove) it in the local POM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
