reta commented on a change in pull request #851:
URL: https://github.com/apache/cxf/pull/851#discussion_r711065380



##########
File path: 
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseImpl.java
##########
@@ -418,7 +418,7 @@ private Link makeAbsoluteLink(Link link) {
 
     public <T> T doReadEntity(Class<T> cls, Type t, Annotation[] anns)
         throws ProcessingException, IllegalStateException {
-        return doReadEntity(cls, t, anns, false);
+        return doReadEntity(cls, t, anns, 
!InputStream.class.isAssignableFrom(cls));

Review comment:
       @andymc12 thanks a lot for your thoughts, indeed closing the response is 
the right thing to do but in case of client proxies, it is not explicit. Using 
finalizers could be an option but they are deprecated since JDK-9 [1] and are 
discouraged. I will look more closely into, it seems like we could isolate the 
client proxies, thank you 
   
   [1] https://bugs.openjdk.java.net/browse/JDK-8165641




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to