ffang commented on pull request #855:
URL: https://github.com/apache/cxf/pull/855#issuecomment-963391917


   Hi @reta , @jimma ,
   
   Surprisingly,  I noticed that in the jakarta jar after transform, the OSGi 
headers by and large are also taken care by the eclipse transformer plugin(some 
magic must happen somewhere that we don't know).
   
   For example, in the cxf-rt-frontend-jaxws-3.5.0-jakarta-SNAPSHOT.jar , the 
Import-Package part is 
   {code}
   Import-Package: jakarta.activation;version="[2.0,3)",jakarta.annotatio
    n;version="[2.0,3)",javax.imageio,javax.imageio.stream,jakarta.jws;ve
    rsion="[0,3)",jakarta.jws.soap;version="[0,3)",jakarta.servlet;resolu
    tion:=optional;version="[5.0,6)",jakarta.servlet.http;resolution:=opt
    ional;version="[5.0,6)",javax.wsdl,javax.wsdl.extensions,javax.wsdl.e
    xtensions.http,javax.wsdl.extensions.soap,javax.wsdl.extensions.soap1
    2,jakarta.xml.bind;version="[3.0,4)",jakarta.xml.bind.annotation;vers
    ion="[3.0,4)",jakarta.xml.bind.annotation.adapters;version="[3.0,4)",
    javax.xml.namespace,jakarta.xml.soap;version="[1.4,2)",javax.xml.stre
    am,javax.xml.transform,javax.xml.transform.dom,javax.xml.transform.sa
    x,javax.xml.transform.stream,javax.xml.validation,jakarta.xml.ws;vers
    ion="[0,3)",jakarta.xml.ws.handler;version="[0,3)",jakarta.xml.ws.han
    dler.soap;version="[0,3)",jakarta.xml.ws.http;version="[0,3)",jakarta
    .xml.ws.soap;version="[0,3)",jakarta.xml.ws.spi;version="[0,3)",jakar
    ta.xml.ws.spi.http;resolution:=optional;version="[0,3)",jakarta.xml.w
    s.wsaddressing;version="[0,3)",org.apache.aries.blueprint;resolution:
    =optional;version="[1.0,2)",org.apache.aries.blueprint.mutable;resolu
    tion:=optional;version="[1.0,2)",org.apache.cxf;version="[3.5,4)",org
    .apache.cxf.annotations;version="[3.5,4)",org.apache.cxf.attachment;v
    ersion="[3.5,4)",org.apache.cxf.binding;version="[3.5,4)",org.apache.
    cxf.binding.soap;version="[3.5,4)",org.apache.cxf.binding.soap.interc
    eptor;version="[3.5,4)",org.apache.cxf.binding.soap.model;version="[3
    .5,4)",org.apache.cxf.binding.soap.saaj;version="[3.5,4)",org.apache.
    cxf.binding.soap.wsdl.extensions;version="[3.5,4)",org.apache.cxf.bin
    ding.xml;version="[3.5,4)",org.apache.cxf.bus.blueprint;version="[3.5
    ,4)",org.apache.cxf.bus.spring;version="[3.5,4)",org.apache.cxf.commo
    n.classloader;version="[3.5,4)",org.apache.cxf.common.i18n;version="[
    3.5,4)",org.apache.cxf.common.injection;version="[3.5,4)",org.apache.
   .....
   {code}
   
   Please notice the jakarta. Import-Package. So I think this eclipse 
transformer plugin has been OSGi friendly already.
   
   @jimma 
   Just one minor issue I found with the GAV pattern after trasform. For 
exmaple, I have 
   ```
   
/Users/ffang/.m2/repository/org/apache/cxf/cxf-rt-frontend-jaxws-3.5.0-jakarta/SNAPSHOT/cxf-rt-frontend-jaxws-3.5.0-jakarta-SNAPSHOT.jar
 
   ```
   The jakarta classfier get inserted between 3.5.0 and SNAPSHOT, IMO, the 
expected path should be like
   ```
   
/Users/ffang/.m2/repository/org/apache/cxf/cxf-rt-frontend-jaxws/3.5.0-SNAPSHOT/cxf-rt-frontend-jaxws-3.5.0-SNAPSHOT-jakarta.jar
 
   ```
   
   Could you please fix it?
   
   Thanks!
   Freeman


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to